Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expand variables button scrolls to page header #2733

Merged
merged 1 commit into from
Aug 13, 2023
Merged

Expand variables button scrolls to page header #2733

merged 1 commit into from
Aug 13, 2023

Conversation

mireq
Copy link
Contributor

@mireq mireq commented Jun 17, 2023

Expansion button is rendered as <a href="#", which scrolls to page header.

To prevent scroll, event.preventDefault should be called or expansion should be changed something else (e.g. button).

@davidism davidism added this to the 2.3.7 milestone Jun 21, 2023
@davidism davidism force-pushed the fix-scroll-on-expand-variables branch from f0ba59f to d927efb Compare August 13, 2023 19:28
@davidism davidism changed the base branch from main to 2.3.x August 13, 2023 19:29
@davidism davidism merged commit 1886322 into pallets:2.3.x Aug 13, 2023
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.7
Development

Successfully merging this pull request may close these issues.
2 participants
@mireq @davidism